Repair vnconfig(8)'s return codes

Repair vnconfig(8)'s return codes The NetBSD Project

Status: Closed Time to complete: 240 hrs Mentors: Radoslaw Kujawa, Julian Coleman, Julian Fagir Tags: C, system

vnconfig(8) is a tool to create virtual disk images. There was a (not officially filed) bug report that it sometimes returns success although it fails:

qemu# vnconfig vnd0 not_existent_file ; echo $? ;: bad vnconfig: not_existent_file: No such file or directory 0 qemu# vnconfig vnd0 existent_file ; echo $? ;: good 0 qemu#

In this task, you will go through the whole work of fixing a bug: You have to analyze the situation, find the source of that bug in the code, and finally fix it.

Uploaded Work

File name/URL	File size	Date submitted
vnconfig.diff	520 bytes	December 01 2012 03:31 UTC

Comments

Philip Hayes on November 28 2012 16:56 UTC Task Claimed

I would like to work on this task.

gnrp on November 28 2012 17:03 UTC Task Assigned

This task has been assigned to Philip Hayes. You have 240 hours to complete this task, good luck!

Radoslaw Kujawa on November 28 2012 22:34 UTC What's up?

Hello, how is it going? Did you manage to install NetBSD and reproduce this problem? In case of any doubts or questions you can write here or visit #netbsd-code channel or irc.freenode.net.

Philip Hayes on November 29 2012 00:16 UTC RE: What's up?

Thanks for checking in! Right now I'm in the process of installing netbsd to my laptop, so I have yet to test anything out yet. However, that said, I have checked out the file in question and have an idea of what the problem is. I'll make sure to get back to you when I finish installing.

Also, what's the difference between #netbsd and #netbsd-code? I'm assuming #netbsd-code is only for coding questions (hence the name)? Should I ask any questions regarding the code-in on #netbsd?

Thanks

- Philip

Radoslaw Kujawa on November 29 2012 00:23 UTC RE: What's up?

#netbsd-code was originally created for Google Summer of Code, but is also now used for Code-In. It is the preferred place to ask questions regarding Code-In tasks. You can find all mentors there. #netbsd is a more general channel.

Philip Hayes on December 1 2012 03:31 UTC Ready for review

The work on this task is ready to be reviewed.

Radoslaw Kujawa on December 1 2012 12:25 UTC Re: Ready for review

Thanks, I'll review as soon as possible (this will take some time, because I need to build the source with your patch applied, test it, etc.).

Radoslaw Kujawa on December 1 2012 22:39 UTC Good job!

Thank you, the patch you have provided is correct. It will be integrated into NetBSD source code soon.

Radoslaw Kujawa on December 1 2012 22:40 UTC Task Closed

Congratulations, this task has been completed successfully.