Logged-In As
ACCOUNT
Not Logged In
Fix an issue (easy) OpenIntents
Status: Closed Time to complete: 336 hrs Mentors: Peli, Friedger Müffke, Randy McEoin, Manuel R. Ciosici Tags: Android, Java

The task is to fix one of the issues from the list of issues.

Your solution should consist of a patch (instructions) based on the latest version of the application. If you dont have it yet, you first need to download and install the Android SDK (instructions). Follow these instructions to build OI applications.

  • Difficulty: easy
  • Time limit: 14 days
  • Prerequisites: Download the Android SDK (instructions)
  • Requirements for completed entry:
    • IMPORTANT: Ask first whether the issue you want to work on is still available and whether you should choose an easy, medium, or hard task.
    • Send in a patch with your code modifications (instructions).
    • The code must follow our StyleGuide.
    • The code must fix the issue.
    • Depending on the number of stars of the issue, select an easy (1 star), medium (2 stars), or hard (3 or more stars) task.
Uploaded Work
File name/URL File size Date submitted
NotesListItemView.patch 1.1 KB December 28 2011 20:57 UTC
Comments
Daniel Huang on December 28 2011 18:57 UTC Task Claimed

I would like to work on this task.

Daniel Huang on December 28 2011 18:57 UTC I would like to claim this task and work on issue 405.

I would like to claim this task and work on issue 405.


 


Issue 405: OI Notepad: Marquee feature does not work properly


 


http://code.google.com/p/openintents/issues/detail?id=405

Randy McEoin on December 28 2011 20:46 UTC Task Assigned

This task has been assigned to Daniel Huang. You have 336 hours to complete this task, good luck!

Daniel Huang on December 28 2011 20:57 UTC Ready for review

The work on this task is ready to be reviewed.

Daniel Huang on December 29 2011 16:02 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Chickenbellyfinn on December 30 2011 03:48 UTC Task Claimed

I would like to work on this task.

Chickenbellyfinn on December 30 2011 03:48 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Peli on December 31 2011 18:15 UTC Patch tried

I tried the patch above, but it does not solve the issue for my device (Nexus One, Android 2.3.6. After some scrolling up and down, I still see blank entries where there should be a note title.


I added a comment to the issue:


http://code.google.com/p/openintents/issues/detail?id=405

Daniel Huang on January 1 2012 19:08 UTC Task Claimed

I would like to work on this task.

Peli on January 1 2012 19:10 UTC Task Assigned

This task has been assigned to Daniel Huang. You have 336 hours to complete this task, good luck!

Daniel Huang on January 1 2012 19:11 UTC Explanation for patch

The issue is mentioned in the page of issue #405:
"If you switch to settings,
change the marquee setting, and press back, the change is not visible immediately. One has to leave the application and start OI Notepad again."

Steps to reproduce the problem:

Open notepad application
- create one note with longer title
- menu-> settings -> enable/or disable marquee setting
- Hit Back, view switch to notepad again from setting
- look at the title of the note, marquee setting is not take effect,
- but if you close notepad application and open it again, marquee is observed for note title.

Root cause:
Marquee handling for title is in constructor, but the constructor is not getting called when the view is changed back from Settings to the notepad application. This causes the
marquee setting to not take effect after switching back from Settings to the notepad view.

Solution:
Move the marquee handling constructor to hasFocus(), which is called whenever the notepad view gets focus.

Verification:

1. Enable/disable marquee from Settings, go back to the notepad view, marquee enable/disable should be observed on title
2. Enable/disable marquee from Settings, close notepad application, open notepad application again, marquee enable/disable should be observed on title

Daniel Huang on January 1 2012 19:19 UTC Ready for review

The work on this task is ready to be reviewed.

Peli on January 1 2012 19:23 UTC Uploaded

Uploaded in revision 3965.

Peli on January 1 2012 19:24 UTC Task Closed

Congratulations, this task has been completed successfully.