Logged-In As
ACCOUNT
Not Logged In
Fix an issue (medium) OpenIntents
Status: Reopened Time to complete: 336 hrs Mentors: Peli, Friedger Müffke, Randy McEoin, aap, Manuel R. Ciosici Tags: Android, Java

The task is to fix one of the issues from the list of issues.

Your solution should consist of a patch (instructions) based on the latest version of the application. If you dont have it yet, you first need to download and install the Android SDK (instructions). Follow these instructions to build OI applications.

  • Difficulty: medium
  • Time limit: 14 days
  • Prerequisites: Download the Android SDK (instructions)
  • Requirements for completed entry:
    • IMPORTANT: Ask first whether the issue you want to work on is still available and whether you should choose an easy, medium, or hard task.
    • Send in a patch with your code modifications (instructions).
    • The code must follow our StyleGuide.
    • The code must fix the issue.
    • Depending on the number of stars of the issue, select an easy (1 star), medium (2 stars), or hard (3 or more stars) task.
Uploaded Work
File name/URL File size Date submitted
master_password.patch 2.0 KB December 11 2011 07:08 UTC
readme.patch 539 bytes December 11 2011 16:12 UTC
keyboard.patch 2.6 KB December 19 2011 10:51 UTC
master_password_2.patch 42.6 KB December 21 2011 09:49 UTC
keyboard_2.patch 2.5 KB December 23 2011 13:45 UTC
Comments
Seve on November 21 2011 20:49 UTC Task Claimed

I would like to work on this task.

Seve on November 21 2011 20:52 UTC To be more specific

I'd like to do Issue 292 if that's available, it has 2 stars. http://code.google.com/p/openintents/issues/detail?id=292&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary%20Stack%20Stars

Peli on November 21 2011 21:11 UTC Task Assigned

This task has been assigned to Seve. You have 336 hours to complete this task, good luck!

Peli on November 21 2011 21:13 UTC Hints

Make sure this works in all lists of OI Safe.

Also, since OI Safe already has a test project, please create a test case, if this is easily possible. (otherwise report why it is not possible).

Seve on November 23 2011 03:17 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Seve on November 23 2011 03:19 UTC Trouble Compiling

I'm having trouble getting things working properly with eclipse :/, if I get it working and this is still available I'll have another go.

Alexandru Florescu on November 24 2011 18:41 UTC Task Claimed

I would like to work on this task.

Alexandru Florescu on November 24 2011 19:32 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Jai Agarwal on December 10 2011 08:38 UTC Task Claimed

I would like to work on this task.

Jai Agarwal on December 10 2011 09:40 UTC Task chosen by me

I am working on Issue 328 which has 2 stars. 

Randy McEoin on December 10 2011 21:03 UTC Task Assigned

This task has been assigned to Jai Agarwal. You have 336 hours to complete this task, good luck!

Jai Agarwal on December 11 2011 07:09 UTC Ready for review

The work on this task is ready to be reviewed.

Peli on December 11 2011 16:37 UTC Question

I have the following question regarding your patch:


* Would it be possible to achieve the same by setting an xml tag in the corresponding layout?


(* Would it make sense / be possible to create a test case for this issue?)

Jai Agarwal on December 12 2011 17:10 UTC Answers

*Yeah, it is possible but I have to customize the keyboard myself.


*Well, I don't think a test case is needed or I should probably say, its not possible to create a test case for this issue.

Peli on December 17 2011 14:25 UTC Problems with patch

I have problems with your patch: How did you create your patch? Did you modify it manually after creation?


The first column usually contains a single blank space, but in your patch this is omitted, and I get the error message "An unknown line type was found in line 5".


(see also here: http://code.google.com/p/openintents/wiki/PatchSubmission )

Peli on December 17 2011 14:25 UTC Task Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Jai Agarwal on December 19 2011 10:50 UTC Ready for review

The work on this task is ready to be reviewed.

Peli on December 21 2011 01:44 UTC Problem with patch

The patch looks better than last time, still I get the following error message:


"An unknown line type was found in line 35".


Did you touch the patch after it was created? You can not edit the patch file manually, because then all line numbers will not fit and this will result in errors.


Edit your original files until everything is ok, then create the patch, and send that unmodified to us. (If you really want to make sure it works, you could apply the patch to a second directory just to check if it works).


You could check one more thing that I could not test: If you select menu > switch mode, will the keyboard be automatically hidden? And will it be shown again if you switch mode back? (or press the small icon in the upper right cornen?)


Does the keyboard stay there even if you change screen orientation?

Peli on December 21 2011 01:44 UTC Task Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Jai Agarwal on December 21 2011 09:49 UTC Ready for review

The work on this task is ready to be reviewed.

Randy McEoin on December 22 2011 01:13 UTC bad patch or formatting

Something is either wrong with the patch generation or you dramatically reformatted AskPassword.java.


We need the .patch file to be only what you changed.   Look at the .patch file.   The way it shows changes is that it specifies the files that changed and the lines that changed within those files.   Lines that need to be removed begin with a minus '-' character and those that need to be added begin with a plus '+' character.


For example, the "readme.txt" file is properly listed in the patch.


--- Safe/readme.txt(revision 3827)
+++ Safe/readme.txt(working copy)
@@ -25,6 +25,11 @@
  http://www.openintents.org

 ---------------------------------------------------------
+release 1.3.0
+date:?
+- automatically open Soft Keyboard in Master Password Screen (Issue 328, Google-Code In patch by Jai Agarwal)
+
+---------------------------------------------------------
 release: 1.2.9


 It indicates that there are some lines that need to be added.  They are the ones above with the '+'.


If you scroll down in the .patch file, you'll see that AskPassword.java is called out.   There you see the entire file, all 668 lines are preceeded by a '-', then a complete replacement with '+'.  So it's replacing the entire file.   There's no way for us to know which lines you actually modified.


Typically when this has happened it's because the user did something in Eclipse to change the formatting, the spaces to tabs or vise versa.


I would advice you to make a copy of AskPassword.java to some other location, then do a "svn revert" of AskPassword.java so you can get the unmodified version.   Then re-incorporate your changes, being very careful to only edit the lines that truly need editing.


keyboard.patch was done correctly.   Please re-do the patch file.

Randy McEoin on December 22 2011 01:13 UTC Task Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Jai Agarwal on December 23 2011 13:46 UTC Ready for review

The work on this task is ready to be reviewed.

Randy McEoin on December 24 2011 20:23 UTC Deadline extended

The deadline of the task has been extended with 2 days and 0 hours.

Jai Agarwal on December 25 2011 16:21 UTC Patch Ready

My Patch is ready. Please Review it.

Jai Agarwal on December 26 2011 03:53 UTC Review

Deadline is coming nearby.. Mentors please review my patch.

Peli on December 26 2011 11:47 UTC Compile time error

Sorry for the delay.


I get the following compile time error in


private InputMethodManager AskPassword.getSystemService()  (line 226 - which only returns null)


"Cannot reduce the visibility of the inherited method from Activity"


 


If I remove this (dummy) method, the application compiles, but upon launching, the software keyboard is not displayed.


Why did you include this (dummy) method? And should things work without this method?

Peli on December 26 2011 11:48 UTC Task Needs More Work

One of the mentors has sent this task back for more work. Talk to the mentor(s) assigned to this task to satisfy the requirements needed to complete this task, submit your work again and mark the task as complete once you re-submit your work.

Peli on December 26 2011 11:48 UTC Deadline extended

The deadline of the task has been extended with 4 days and 0 hours.

Jai Agarwal on December 28 2011 09:23 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Darriel on December 29 2011 08:24 UTC Task Claimed

I would like to work on this task.

Darriel on December 29 2011 08:27 UTC Issue 201

I want to try to work on http://code.google.com/p/openintents/issues/detail?id=201&colspec=ID%20Type%20Status%20Priority%20Milestone%20Owner%20Summary%20Stack%20Stars


Any preferences on how to solve it? Would you like it if a pop up appears saying "Backup found, restore? (button)YES (button)NO" On clicking yes, BackUp activity starts, on clicking No, the 'front door' action goes on.

Darriel on December 29 2011 11:28 UTC Question

Which files handle the restore backup action and the displaying of option of a restore of backup when started for the first time? Are the following lines from "Restore" doing something about this:



        firstTime = icicle != null ? icicle.getBoolean(Restore.KEY_FIRST_TIME) : false;
        if (firstTime == false) {
            Bundle extras = getIntent().getExtras();           
            firstTime = extras != null ? extras.getBoolean(Restore.KEY_FIRST_TIME) : false;
        }


And does the IntentHandler do something about it?


 

Darriel on December 29 2011 11:58 UTC Task

I will drop this task now, as I got interested in another one, but I will probably work on this one later, if it doesn't get resolved by another student.

Darriel on December 29 2011 11:58 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Chickenbellyfinn on December 31 2011 15:55 UTC Task Claimed

I would like to work on this task.

Chickenbellyfinn on December 31 2011 16:01 UTC Issue 151

I woyuld like to work on issue 151,  WiiMote data subject to locale

Peli on December 31 2011 16:03 UTC Task Assigned

This task has been assigned to Chickenbellyfinn. You have 336 hours to complete this task, good luck!

Peli on December 31 2011 16:04 UTC SensorSimulator

This issue applies to SensorSimulator. Note that I don't know whether the WiiMote extension is still compatible with the current version. This would have to be checked first.

Chickenbellyfinn on January 2 2012 20:43 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Matěj Konečný on January 10 2012 06:26 UTC Task Claimed

I would like to work on this task.

Matěj Konečný on January 10 2012 06:26 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.

Chickenbellyfinn on January 11 2012 03:19 UTC Task Claimed

I would like to work on this task.

Chickenbellyfinn on January 11 2012 03:21 UTC Issue 433

I would like to work on issue 433, keep scroll position of long note.

Peli on January 11 2012 19:42 UTC Task Assigned

This task has been assigned to Chickenbellyfinn. You have 336 hours to complete this task, good luck!

Peli on January 11 2012 19:43 UTC Warning

I have to warn you - this may also be a tricky task. The previous student could not find a solution and gave up...

Chickenbellyfinn on January 11 2012 22:20 UTC Claim Removed

The claim on this task has been removed, someone else can claim it now.